Skip to content

Conversation

@paulrosca-snyk
Copy link
Contributor

@paulrosca-snyk paulrosca-snyk commented Nov 11, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Commit messages
    are release-note ready, emphasizing
    what was changed, not how.
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)
  • Includes product update to be announced in the next stable release notes

What does this PR do?

Bumps cli-extension-os-flows and cli-extension-dep-graph to the latest versions, in order to fix any discrepancies in the output, compared to the legacy CLI.

Wraps the snyk test tests in user journey table tests, with only the legacy workflow test enabled. The go workflow implementation will be enabled in a following PR, alongside with enabling the feature flags required to access it, on the cli testing org.

Where should the reviewer start?

How should this be manually tested?

What's the product update that needs to be communicated to CLI users?

N/A

@paulrosca-snyk paulrosca-snyk force-pushed the feat(test)/new-extension-table-tests branch 3 times, most recently from 310861f to fe040e7 Compare November 11, 2025 14:00
@paulrosca-snyk paulrosca-snyk marked this pull request as ready for review November 11, 2025 15:17
@paulrosca-snyk paulrosca-snyk requested review from a team as code owners November 11, 2025 15:17
@paulrosca-snyk paulrosca-snyk force-pushed the feat(test)/new-extension-table-tests branch from fe040e7 to 408b979 Compare November 11, 2025 15:38
env,
});

if (code != 0) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Do you want to extend and re-use this, instead of having the following code block the tests?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, I just see that it is only copied

Copy link
Contributor

@PeterSchafer PeterSchafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: this is probably not a feat, consider using chore. Feat are used for user facing changes.

@nicarl nicarl force-pushed the feat(test)/new-extension-table-tests branch from 408b979 to d84e30f Compare November 11, 2025 16:59
@nicarl nicarl enabled auto-merge November 11, 2025 16:59
@nicarl nicarl force-pushed the feat(test)/new-extension-table-tests branch from d84e30f to 3e76ece Compare November 11, 2025 17:33
@nicarl nicarl merged commit 05fed55 into main Nov 11, 2025
5 checks passed
@nicarl nicarl deleted the feat(test)/new-extension-table-tests branch November 11, 2025 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants