Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add fips status #4791

Merged
merged 4 commits into from
Aug 11, 2023
Merged

feat: add fips status #4791

merged 4 commits into from
Aug 11, 2023

Conversation

PeterSchafer
Copy link
Collaborator

What does this PR do?

  • Show fips status in logs
  • Panic if fips is enabled in a non fips CLI

Where should the reviewer start?

How should this be manually tested?

WIth a CLI that wasn't build with FIPS enabled, running the call below should panic

GOFIPS=1 snyk test

Setting GOFIPS=0 the CLI should run normally.

Any background context you want to provide?

What are the relevant tickets?

Screenshots

image

Additional questions

@PeterSchafer PeterSchafer requested a review from a team as a code owner August 11, 2023 09:38
Copy link
Contributor

@j-luong j-luong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing this is going to be tested by HEAD-393?

@PeterSchafer PeterSchafer force-pushed the feat/HEAD-394_fips_functionality branch from 348341b to 2023f58 Compare August 11, 2023 12:51
@PeterSchafer PeterSchafer force-pushed the feat/HEAD-394_fips_functionality branch from 289668c to a35371e Compare August 11, 2023 13:43
@PeterSchafer PeterSchafer enabled auto-merge (squash) August 11, 2023 14:08
@PeterSchafer PeterSchafer merged commit 364c365 into master Aug 11, 2023
5 checks passed
@PeterSchafer PeterSchafer deleted the feat/HEAD-394_fips_functionality branch August 11, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants