feat: bump snyk-docker-plugin to include openjdk analyser fix #365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit 7f41eac1e3a introduced a change to snyk-docker-plugin where the subprocess module would return both stdout and stderr. unfortunately, due to backward compatibility considerations, java's "-version" command outputs strictly to stderr; naively, we were looking for stdout. (https://stackoverflow.com/questions/17968856/redirect-to-stdout-in-bash) the fix in snyk-docker-plugin propagates both stdout and stderr for further parsing.
leongold
force-pushed
the
feat/bump-version
branch
from
fdb5490
to
2545dbe
Compare
leongold
changed the title
darmalovan
approved these changes
Feb 13, 2019
|
🎉 This PR is included in version 1.129.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Sep 22, 2021
This was referenced Apr 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit 7f41eac1e3a introduced a change to snyk-docker-plugin
where the subprocess module would return both stdout and stderr.
unfortunately, due to backward compatibility considerations,
java's "-version" command outputs strictly to stderr; naively,
we were looking for stdout.
(https://stackoverflow.com/questions/17968856/redirect-to-stdout-in-bash)
the fix in snyk-docker-plugin propagates both stdout and stderr
for further parsing.