refactor: test command rewritten to TS #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kirill89
requested review from
lili2311,
darmalovan,
miiila,
orkamara,
karniwl and
ArturSnyk
|
@Kirill89 if you are at-it, maybe you can also add some type annotations? |
|
@michael-go let’s do it in next round of refactoring? My main target was to make promise hell more readable. |
Kirill89
force-pushed
the
refactor/commands-test
branch
from
15554c6
to
de7f2b9
Compare
darmalovan
approved these changes
Jan 22, 2019
|
There is a conflict here, but I approved @Kirill89 |
|
@Kirill89 we can merge the conflicts together |
Kirill89
force-pushed
the
refactor/commands-test
branch
from
de7f2b9
to
2080fa0
Compare
|
🎉 This PR is included in version 1.122.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
testcommand rewritten to TS.