Conversation
miiila
reviewed
Oct 30, 2018
Contributor
miiila
left a comment
miiila
left a comment
There was a problem hiding this comment.
I'd like to clarify two things before approving:
- please address comment around https://github.com/snyk/snyk/pull/257/files#diff-7d011e4c9a3d66fcafd27dede7916a27R17 as it would cause a lot of confusion in the future
- could you please elaborate a bit on the move from
updatetoinstall|installDev? I believe it's related toAlso fixing how we regenerate the lockfile if user selected to add snyk to dependencies., but I am not sure I understood the difference.
Also amend how we re-lock the lockfile
lili2311
force-pushed
the
fix/file-path-fix
branch
10 times, most recently
from
24a3641 to
9c6ee03
Compare
lili2311
force-pushed
the
fix/file-path-fix
branch
from
9c6ee03 to
4d8aa01
Compare
|
🎉 This PR is included in version 1.105.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also amend how we re-lock the lockfile
What does this PR do?
Fixes a bug where for package-lock.json projects we are relying on the assumed patch paths for patching (since the lockfile is the exact shape of the
node_modules)The bug was around us using
cwdwhich is mostly used for tests and this was returning path paths like:/npm/node_modules/path-to-module/instead of/node_modules/path-to-module/Also fixing how we regenerate the lockfile if user selected to add snyk to dependencies. Update is relying on having the vuln from paths present, so skipping straight past all this and directly calling
install&&installDevsince addingsnykis not part of the vuln testing flowWhere should the reviewer start?
https://github.com/snyk/snyk/compare/fix/file-path-fix?expand=1#diff-7d011e4c9a3d66fcafd27dede7916a27R17
How should this be manually tested?
Project
goofcan be used after adding a lockfile as an example