Skip to content

Conversation

@karniwl
Copy link
Contributor

@karniwl karniwl commented Oct 21, 2018

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Removes display of number of vulnerable paths for docker, since currently the count is inaccurate for several reasons:

  1. the trees are trimmed quite aggressively in snyk-docker-plugin to reduce size.
  2. for rpm & apk based images, we don't differentiate between packages installed manually vs. transitives that were installed automatically.

What are the relevant tickets?

Jira ticket SC-6459

@karniwl karniwl self-assigned this Oct 21, 2018
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2018

CLA assistant check
All committers have signed the CLA.

@michael-go
Copy link
Contributor

michael-go commented Oct 21, 2018

this better be a fix: commit, rather than feat: .

and please note that the commit message appears later in the Release Notes (https://github.com/snyk/snyk/releases) so maybe reword with:
fix: don't print vulnerable paths count for docker tests

and we better give a reason in the PR body to why we do it. Maybe can just say it's because right now the count is not accurate for several reasons:

  1. the trees are trimmed quite aggressively in snyk-docker-plugin to reduce size
  2. for rpm & apk based images, we don't differentiate between packages installed manually vs. transitives that were installed automatically

@karniwl karniwl force-pushed the feat/rm-num-of-vuln-paths branch from a3d613a to 2aedc08 Compare October 22, 2018 11:18
@karniwl karniwl force-pushed the feat/rm-num-of-vuln-paths branch from 2aedc08 to eb06722 Compare October 22, 2018 11:22
@karniwl karniwl changed the title feat: remove number of vulnerable paths for docker fix: don't print vulnerable paths count for docker tests Oct 22, 2018
@karniwl karniwl merged commit be98a50 into master Oct 23, 2018
@karniwl karniwl deleted the feat/rm-num-of-vuln-paths branch October 23, 2018 09:47
@snyksec
Copy link

snyksec commented Oct 23, 2018

🎉 This PR is included in version 1.104.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants