chore: upgrade sinon #250
Merged
chore: upgrade sinon #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Contributor
|
@DanielRuf can you please sign the CLA on this PR? I changed the base branch so we can merge it in and then open an internal PR to master. I'll do so once you sign the CLA 🙏 |
Author
Done. |
Contributor
|
Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upgrade sinon
Where should the reviewer start?
How should this be manually tested?
Any background context you want to provide?
Resolve the deprecated warnings.
What are the relevant tickets?
Screenshots
Additional questions