-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[COD-152] feat: analytics added to snykcode flow #1730
Conversation
@@ -25,6 +26,7 @@ export const codePlugin: EcosystemPlugin = { | |||
async test(paths, options) { | |||
try { | |||
await validateCodeTest(options); | |||
analytics.add('sast-scan', true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question
: I have a vague memory of these things being required somewhere else. Did you discuss it with somebody who has more BI insights?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, those keys needs to be defined in registry src/lib/analytics/cli.ts
, because we are not collecting free-form analytics keys anymore… for reasons
abc9fc9
to
a442e80
Compare
928223c
to
e3d058f
Compare
e3d058f
to
143c363
Compare
143c363
to
4e8e35b
Compare
Expected release notes (by @Spoor2709) features:
|
COD-152
What does this PR do?
The pr adds analytics to snykcode flow in the cli