Fix failing docker image builds#173
Closed
julienduchesne wants to merge 1 commit intosnyk:fix/dockerfilesfrom
julienduchesne:fix-failing-docker-builds
Closed
Fix failing docker image builds#173julienduchesne wants to merge 1 commit intosnyk:fix/dockerfilesfrom julienduchesne:fix-failing-docker-builds
julienduchesne wants to merge 1 commit intosnyk:fix/dockerfilesfrom
julienduchesne:fix-failing-docker-builds
Conversation
Contributor
Author
|
As you can see here: https://hub.docker.com/r/coveo/snyk/builds/. All builds work now. |
Contributor
|
Thank you, this looks great! @odinn1984 Can you take a look when you get a chance please? |
darscan
reviewed
Jul 6, 2018
| RUN wget http://www-eu.apache.org/dist/maven/maven-3/3.5.2/binaries/apache-maven-3.5.2-bin.tar.gz | ||
| RUN tar -xvzf apache-maven-3.5.2-bin.tar.gz | ||
| RUN rm -f apache-maven-3.5.2-bin.tar.gz | ||
| RUN wget http://www-eu.apache.org/dist/maven/maven-3/3.5.4/binaries/apache-maven-3.5.4-bin.tar.gz |
Contributor
There was a problem hiding this comment.
Should this be https rather?
Contributor
|
@julienduchesne we'll grab this PR to give it our special treatment and release sometime soon... Stay tuned. |
Contributor
|
@julienduchesne THANK YOU so much for this PR. It is now included in release 1.89.0, docker images are being built on https://hub.docker.com/r/snyk/snyk-cli/tags/ I kept you as the author on the commits, sorry we couldn't just merge your PR as is (our release process is not very straightforward right now). |
Contributor
Author
|
No problem. Thanks for merging! |
This was referenced Jan 31, 2020
This was referenced Sep 15, 2021
This was referenced Aug 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
All java docker images are currently failing their builds. This PR fixes this.
RUN mkdir -p /usr/share/man/man1as suggested in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=863199 to fix theoracle-java8-installerfailing installation.