Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fallback to type when missing targetFile #1729

Merged
merged 1 commit into from
Mar 16, 2021

Conversation

lili2311
Copy link
Contributor

@lili2311 lili2311 commented Mar 16, 2021

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

  • some remote scans do not have much information to use to identify the scanned project. If we don't have targetFile for now fallback to ${type} project e.g. npm project

Screenshots

Before
CleanShot 2021-03-16 at 09 47 00@2x

After
CleanShot 2021-03-16 at 10 23 17@2x

@lili2311 lili2311 self-assigned this Mar 16, 2021
@lili2311 lili2311 requested a review from a team as a code owner March 16, 2021 10:24
@github-actions
Copy link
Contributor

github-actions bot commented Mar 16, 2021

Expected release notes (by @lili2311)

features:
fallback to type when missing targetFile (d22eca8)

others (will not be included in Semantic-Release notes):
remove windows-specific test paths Jest uses micromatch for these paths which should handle Windows automatically. (9c06c52)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@lili2311 lili2311 merged commit 1014be3 into master Mar 16, 2021
@lili2311 lili2311 deleted the feat/fall-back-to-project-type branch March 16, 2021 10:29
This was referenced Mar 16, 2021
This was referenced Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants