Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add unit tests for tf plan parsing #1720

Closed
wants to merge 1 commit into from
Closed

test: add unit tests for tf plan parsing #1720

wants to merge 1 commit into from

Conversation

rontalx
Copy link
Contributor

@rontalx rontalx commented Mar 14, 2021 •
edited
Loading

** need to rebase with: #1731

Adding missing unit-tests for Terraform Plan parsing.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 14, 2021 •
edited
Loading

Warnings
⚠️

Looks like you added a new Tap test. Consider making it a Jest test instead. See files like test/*.spec.ts for examples. Files found:

  • test/jest/unit/iac-unit-tests/terraform-plan-parser.fixtures.ts

Generated by 🚫 dangerJS against 7497d78

@rontalx rontalx force-pushed the test/iac-local-exec-unit-tests branch 2 times, most recently from c5d8dfe to c25f99c Compare March 14, 2021 15:14
@rontalx rontalx marked this pull request as ready for review March 16, 2021 08:50
@rontalx rontalx requested review from a team and p0tr3c March 16, 2021 08:50
@rontalx rontalx requested review from a team as code owners March 16, 2021 13:01
@rontalx rontalx force-pushed the test/iac-local-exec-unit-tests branch from be7f5be to c25f99c Compare March 16, 2021 13:19
@rontalx rontalx marked this pull request as draft March 17, 2021 08:36
@rontalx rontalx removed request for a team March 17, 2021 08:36
@rontalx rontalx force-pushed the test/iac-local-exec-unit-tests branch from c25f99c to cc9331a Compare March 17, 2021 12:39
@rontalx rontalx force-pushed the test/iac-local-exec-unit-tests branch from cc9331a to 7497d78 Compare March 17, 2021 12:39
@rontalx rontalx changed the base branch from master to fix/jest-config-not-provided March 17, 2021 12:40
@github-actions
Copy link
Contributor

Expected release notes (by @rontalx)

fixes:
jest skipping iac unit-tests + fixed failing tests (7497d78)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@rontalx rontalx closed this Mar 17, 2021
@darscan darscan deleted the test/iac-local-exec-unit-tests branch January 20, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0tr3c p0tr3c Awaiting requested review from p0tr3c

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rontalx