Merge pull request #2178 from snyk/test/server-close

test: server.close uses callbacks, not promises
snyk · Aug 20, 2021 · e7c314f · e7c314f
2 parents 55e88f9 + 1522c5f
commit e7c314f
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 6 deletions.
diff --git a/test/jest/acceptance/oauth-token.spec.ts b/test/jest/acceptance/oauth-token.spec.ts
@@ -22,8 +22,8 @@ describe('test using OAuth token', () => {
     server.listen(apiPort, () => done());
   });
 
-  afterAll(async () => {
-    await server.close();
+  afterAll((done) => {
+    server.close(() => done());
   });
 
   it('successfully tests a project with an OAuth env variable set', async () => {

diff --git a/test/jest/system/lib/commands/fix/fix.spec.ts b/test/jest/system/lib/commands/fix/fix.spec.ts
@@ -36,8 +36,8 @@ describe('snyk fix (system tests)', () => {
     });
   });
 
-  afterAll(async () => {
-    await server.close();
+  afterAll((done) => {
+    server.close(() => done());
   });
 
   it(

diff --git a/test/system/cli.test.ts b/test/system/cli.test.ts
@@ -409,7 +409,9 @@ after('teardown', async (t) => {
   delete process.env.SNYK_PORT;
   t.notOk(process.env.SNYK_PORT, 'fake env values cleared');
 
-  await server.close();
+  await new Promise<void>((resolve) => {
+    server.close(resolve);
+  });
   t.pass('server shutdown');
   let key = 'set';
   let value = 'api=' + oldKey;

diff --git a/test/system/remote-package.test.ts b/test/system/remote-package.test.ts
@@ -209,7 +209,9 @@ after('teardown', async (t) => {
   delete process.env.SNYK_PORT;
   t.notOk(process.env.SNYK_PORT, 'fake env values cleared');
 
-  await server.close();
+  await new Promise<void>((resolve) => {
+    server.close(resolve);
+  });
   t.pass('server shutdown');
   let key = 'set';
   let value = 'api=' + oldkey;