Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add version check to CircleCI #31

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Conversation

maxjeffos
Copy link
Contributor

Add version check to CircleCI so that we don't create a release (with semantic-release) with an incorrect version in the plugin.yaml

…e (with semantic-release) with an incorrect version in the plugin.yaml
@maxjeffos maxjeffos requested a review from agranado2k November 28, 2019 21:47
Copy link
Contributor

@agranado2k agranado2k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM! However I don't think it is the best solution. I included few comments in the ticket that suppose solve it here

@maxjeffos
Copy link
Contributor Author

This just adds a level of protection so that we don't accidentally create a release where the version from semantic-release (which ends up being the version tag on the GitHub releases) which is out of sync with the version specified in plugin.yaml. It still requires that we correctly set the version in plugin.yaml. We have another ticket open to address the versioning in such a way as to automatically set the version correctly during the PR merge - see https://snyksec.atlassian.net/browse/BDE-33 and comments in https://snyksec.atlassian.net/jira/software/projects/BDE/boards/95?selectedIssue=BDE-40.

@maxjeffos maxjeffos merged commit ed0ed1a into master Nov 29, 2019
@maxjeffos maxjeffos deleted the chore/version-check-in-circleci branch November 29, 2019 16:06
@snyksec
Copy link

snyksec commented Apr 17, 2020

🎉 This PR is included in version 1.2.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@snyksec
Copy link

snyksec commented Apr 17, 2020

🎉 This PR is included in version 1.2.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants