This repository has been archived by the owner on Feb 23, 2022. It is now read-only.
Add new applications icons #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can't reasonably review all of these in one MR |
|
They are just icon's sources files. I tried to organize them through commits |
|
I'm open to suggestion to open better PR |
|
I appreciate the initiative, but PRs should be one (or a few) icons at a time! It's not about organization it's too many changes/additions to review in one pull request. I can't reasonably address any potential fixes required in a PR this large. I haven't looked at all of them, but the few I have glanced at are not in Moka-style and just appear to be another icon pasted onto a Moka-style background. Rendering them is also a required step. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about 30 icons added that more target main deepin applications.
There is also some apps' icons adjusments from latest associated logo version:
New icon:
Little fix in generate-symlink.sh