Skip to content

[MINOR] Update checkstyle plugin version to avoid security vulnerability #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[MINOR] Update checkstyle plugin version to avoid security vulnerability #183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5edc2f
Update checkstyle plugins to avoid security vulnerability
yunseong Mar 17, 2019
ae1d6e4
Merge branch 'master' into ys-fix-checkstyle-version
yunseong Mar 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dolphin-ps/src/main/java/edu/snu/dolphin/ps/server/concurrent/api/ServerSideMsgSender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,5 +34,5 @@ public interface ServerSideMsgSender<K, V> {
* @param key key object associated with the expected value
* @param valueEntry {@link ValueEntry} object containing the requested value
*/
void sendReplyMsg(final String destId, final K key, final ValueEntry<V> valueEntry);
void sendReplyMsg(String destId, K key, ValueEntry<V> valueEntry);
}
4 changes: 2 additions & 2 deletions dolphin-ps/src/main/java/edu/snu/dolphin/ps/worker/concurrent/WorkerSideMsgSender.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ public interface WorkerSideMsgSender<K, P> {
* @param key key object representing what is being sent
* @param preValue value to be sent to the destination
*/
void sendPushMsg(final String destId, final K key, final P preValue);
void sendPushMsg(String destId, K key, P preValue);

/**
* Send a request to another evaluator for fetching a certain value.
Expand All @@ -40,5 +40,5 @@ public interface WorkerSideMsgSender<K, P> {
* @param destId Network Connection Service identifier of the destination evaluator
* @param key key object representing the expected value
*/
void sendPullMsg(final String destId, final K key);
void sendPullMsg(String destId, K key);
}
2 changes: 1 addition & 1 deletion dolphin-ps/src/main/java/edu/snu/dolphin/util/AvroUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ private AvroUtils() {
public static <T> byte[] toBytes(final T avroObject, final Class<T> theClass) {
final DatumWriter<T> datumWriter = new SpecificDatumWriter<>(theClass);
final byte[] theBytes;
try (final ByteArrayOutputStream out = new ByteArrayOutputStream()) {
try (ByteArrayOutputStream out = new ByteArrayOutputStream()) {
final BinaryEncoder encoder = EncoderFactory.get().binaryEncoder(out, null);
datumWriter.write(avroObject, encoder);
encoder.flush();
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
<hadoop.version>2.4.0</hadoop.version>
<mahout.version>0.9</mahout.version>
<rat.version>0.11</rat.version>
<maven-checkstyle-plugin.version>2.17</maven-checkstyle-plugin.version>
<maven-checkstyle-plugin.version>3.0.0</maven-checkstyle-plugin.version>
<checkstyle.version>8.18</checkstyle.version>
<protobuf.version>2.5.0</protobuf.version>
<avro.version>1.7.7</avro.version>
Expand Down