tails, inits, initTails example implementation #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snoyberg
requested changes
Jul 2, 2023
|
I'll try to add some tests this week |
snoyberg
approved these changes
Nov 14, 2023
BebeSparkelSparkel
force-pushed
the
master
branch
from
02a37e7
to
baccd02
Compare
|
Added tests and fixed error for list instance. Question: Should |
|
I honestly have no idea, I've never used that function. Is there any prior art you're aware of for a definition? |
|
One invariant of this function seems to be that therefore |
|
I have received comment from @tomjaguarpaw above and Atijohn. Both recommend So, this is ready to go. |
snoyberg
reviewed
Feb 27, 2024
| @@ -472,6 +472,31 @@ class (Monoid seq, MonoTraversable seq, SemiSequence seq, MonoPointed seq) => Is | |||
| splitWhen :: (Element seq -> Bool) -> seq -> [seq] | |||
| splitWhen = defaultSplitWhen | |||
|
|
|||
| -- | Returns all the final segments of 'seq' with the longest first. | |||
| -- | |||
| -- @since ???? | |||
There was a problem hiding this comment.
Once these are updated, I'll be happy to merge and release. Thanks!
It seems that the definitions for inits and tails differs between String and ByteString.
Benchmarks showed that some specialized instances of initTails based on splitOn were slower than the default definition, so I removed them. Added reccommended flags for benchmarking. Added change log entry.
BebeSparkelSparkel
force-pushed
the
master
branch
from
23c5825
to
648f1f5
Compare
snoyberg
approved these changes
Feb 28, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my example implementation. I have only added:
tails,inits,initTailstoclass IsSequenceCan you review for correctness and then I will add it to the other instances?
I am unsure how to add this to tests. How should I add the tests?
closes #213