Skip to content

Commit

Permalink
Merge pull request #180 from dcastro/master
Browse files Browse the repository at this point in the history
Added `WrappedMono` newtype (solved #179)
  • Loading branch information
snoyberg authored Oct 3, 2019
2 parents 9db347f + 2de4326 commit e71e18b
Show file tree
Hide file tree
Showing 13 changed files with 48 additions and 317 deletions.
198 changes: 9 additions & 189 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,153 +34,44 @@ cache:
# addons: {apt: {packages: [libfcgi-dev,libgmp-dev]}}
matrix:
include:
# We grab the appropriate GHC and cabal-install versions from hvr's PPA. See:
# https://github.com/hvr/multi-ghc-travis
#- env: BUILD=cabal GHCVER=7.0.4 CABALVER=1.16 HAPPYVER=1.19.5 ALEXVER=3.1.7
# compiler: ": #GHC 7.0.4"
# addons: {apt: {packages: [cabal-install-1.16,ghc-7.0.4,happy-1.19.5,alex-3.1.7], sources: [hvr-ghc]}}
#- env: BUILD=cabal GHCVER=7.2.2 CABALVER=1.16 HAPPYVER=1.19.5 ALEXVER=3.1.7
# compiler: ": #GHC 7.2.2"
# addons: {apt: {packages: [cabal-install-1.16,ghc-7.2.2,happy-1.19.5,alex-3.1.7], sources: [hvr-ghc]}}
#- env: BUILD=cabal GHCVER=7.4.2 CABALVER=1.16 HAPPYVER=1.19.5 ALEXVER=3.1.7
# compiler: ": #GHC 7.4.2"
# addons: {apt: {packages: [cabal-install-1.16,ghc-7.4.2,happy-1.19.5,alex-3.1.7], sources: [hvr-ghc]}}
#- env: BUILD=cabal GHCVER=7.6.3 CABALVER=1.16 HAPPYVER=1.19.5 ALEXVER=3.1.7
# compiler: ": #GHC 7.6.3"
# addons: {apt: {packages: [cabal-install-1.16,ghc-7.6.3,happy-1.19.5,alex-3.1.7], sources: [hvr-ghc]}}
#- env: BUILD=cabal GHCVER=7.8.4 CABALVER=1.18 HAPPYVER=1.19.5 ALEXVER=3.1.7
# compiler: ": #GHC 7.8.4"
# addons: {apt: {packages: [cabal-install-1.18,ghc-7.8.4,happy-1.19.5,alex-3.1.7], sources: [hvr-ghc]}}
#- env: BUILD=cabal GHCVER=7.10.3 CABALVER=1.22 HAPPYVER=1.19.5 ALEXVER=3.1.7
# compiler: ": #GHC 7.10.3"
# addons: {apt: {packages: [cabal-install-1.22,ghc-7.10.3,happy-1.19.5,alex-3.1.7], sources: [hvr-ghc]}}

# Disabling cabal for now, the dependency structure here confuses it.

#- env: BUILD=cabal GHCVER=8.0.2 CABALVER=1.24 HAPPYVER=1.19.5 ALEXVER=3.1.7
# compiler: ": #GHC 8.0.2"
# addons: {apt: {packages: [cabal-install-1.24,ghc-8.0.2,happy-1.19.5,alex-3.1.7], sources: [hvr-ghc]}}
#- env: BUILD=cabal GHCVER=8.2.2 CABALVER=2.0 HAPPYVER=1.19.5 ALEXVER=3.1.7
# compiler: ": #GHC 8.2.2"
# addons: {apt: {packages: [cabal-install-2.0,ghc-8.2.2,happy-1.19.5,alex-3.1.7], sources: [hvr-ghc]}}
#- env: BUILD=cabal GHCVER=8.4.4 CABALVER=2.2 HAPPYVER=1.19.5 ALEXVER=3.1.7
# compiler: ": #GHC 8.4.4"
# addons: {apt: {packages: [cabal-install-2.2,ghc-8.4.4,happy-1.19.5,alex-3.1.7], sources: [hvr-ghc]}}
#- env: BUILD=cabal GHCVER=8.6.3 CABALVER=2.2 HAPPYVER=1.19.5 ALEXVER=3.1.7
# compiler: ": #GHC 8.6.3"
# addons: {apt: {packages: [cabal-install-2.4,ghc-8.6.3,happy-1.19.5,alex-3.1.7], sources: [hvr-ghc]}}

# Build with the newest GHC and cabal-install. This is an accepted failure,
# see below.
#- env: BUILD=cabal GHCVER=head CABALVER=head HAPPYVER=1.19.5 ALEXVER=3.1.7
# compiler: ": #GHC HEAD"
# addons: {apt: {packages: [cabal-install-head,ghc-head,happy-1.19.5,alex-3.1.7], sources: [hvr-ghc]}}

# The Stack builds. We can pass in arbitrary Stack arguments via the ARGS
# variable, such as using --stack-yaml to point to a different file.
- env: BUILD=stack ARGS=""
compiler: ": #stack default"
addons: {apt: {packages: [libgmp-dev]}}

#- env: BUILD=stack ARGS="--resolver lts-2"
# compiler: ": #stack 7.8.4"
# addons: {apt: {packages: [libgmp-dev]}}

#- env: BUILD=stack ARGS="--resolver lts-3"
# compiler: ": #stack 7.10.2"
# addons: {apt: {packages: [libgmp-dev]}}

#- env: BUILD=stack ARGS="--resolver lts-6"
# compiler: ": #stack 7.10.3"
# addons: {apt: {packages: [libgmp-dev]}}

#- env: BUILD=stack ARGS="--resolver lts-7"
# compiler: ": #stack 8.0.1"
# addons: {apt: {packages: [libgmp-dev]}}

- env: BUILD=stack ARGS="--stack-yaml stack-lts-9.yaml"
compiler: ": #stack 8.0.2"
addons: {apt: {packages: [libgmp-dev]}}

- env: BUILD=stack ARGS="--resolver lts-11"
compiler: ": #stack 8.2.2"
compiler: ": #GHC 8.2 Linux"
addons: {apt: {packages: [libgmp-dev]}}

- env: BUILD=stack ARGS="--resolver lts-12"
compiler: ": #stack 8.4.4"
compiler: ": #GHC 8.4 Linux"
addons: {apt: {packages: [libgmp-dev]}}

- env: BUILD=stack ARGS="--resolver lts-14"
compiler: ": #stack 8.6.5"
compiler: ": #GHC 8.6 Linux"
addons: {apt: {packages: [libgmp-dev]}}

- env: BUILD=stack ARGS="--stack-yaml stack-nightly.yaml"
compiler: ": #stack 8.8.1"
addons: {apt: {packages: [libgmp-dev]}}

# Nightly builds are allowed to fail
- env: BUILD=stack ARGS="--resolver nightly"
compiler: ": #stack nightly"
compiler: ": #GHC 8.8 Linux"
addons: {apt: {packages: [libgmp-dev]}}

# Build on macOS in addition to Linux
- env: BUILD=stack ARGS=""
compiler: ": #stack default osx"
os: osx

# Travis includes an macOS which is incompatible with GHC 7.8.4
#- env: BUILD=stack ARGS="--resolver lts-2"
# compiler: ": #stack 7.8.4 osx"
# os: osx

#- env: BUILD=stack ARGS="--resolver lts-3"
# compiler: ": #stack 7.10.2 osx"
# os: osx

#- env: BUILD=stack ARGS="--resolver lts-6"
# compiler: ": #stack 7.10.3 osx"
# os: osx

#- env: BUILD=stack ARGS="--resolver lts-7"
# compiler: ": #stack 8.0.1 osx"
# os: osx

- env: BUILD=stack ARGS="--stack-yaml stack-lts-9.yaml"
compiler: ": #stack 8.0.2 osx"
os: osx

- env: BUILD=stack ARGS="--resolver lts-11"
compiler: ": #stack 8.2.2 osx"
compiler: ": #GHC 8.2 OS X"
os: osx

- env: BUILD=stack ARGS="--resolver lts-12"
compiler: ": #stack 8.4.4 osx"
compiler: ": #GHC 8.4 OS X"
os: osx

- env: BUILD=stack ARGS="--resolver lts-14"
compiler: ": #stack 8.6.5 osx"
compiler: ": #GHC 8.6 OS X"
os: osx

- env: BUILD=stack ARGS="--stack-yaml stack-nightly.yaml"
compiler: ": #stack 8.8.1"
os: osx

- env: BUILD=stack ARGS="--resolver nightly"
compiler: ": #stack nightly osx"
compiler: ": #GHC 8.8 OS X"
os: osx

allow_failures:
- env: BUILD=cabal GHCVER=head CABALVER=head HAPPYVER=1.19.5 ALEXVER=3.1.7
- env: BUILD=stack ARGS="--resolver nightly"

before_install:
# Using compiler above sets CC to an invalid value, so unset it
- unset CC

# We want to always allow newer versions of packages when building on GHC HEAD
- CABALARGS=""
- if [ "x$GHCVER" = "xhead" ]; then CABALARGS=--allow-newer; fi

# Download and unpack the stack executable
- export PATH=/opt/ghc/$GHCVER/bin:/opt/cabal/$CABALVER/bin:$HOME/.local/bin:/opt/alex/$ALEXVER/bin:/opt/happy/$HAPPYVER/bin:$HOME/.cabal/bin:$PATH
- mkdir -p ~/.local/bin
Expand All @@ -192,76 +83,5 @@ before_install:
travis_retry curl -L https://get.haskellstack.org/stable/linux-x86_64.tar.gz | tar xz --wildcards --strip-components=1 -C ~/.local/bin '*/stack'
fi
# Use the more reliable S3 mirror of Hackage
mkdir -p $HOME/.cabal
echo 'remote-repo: hackage.haskell.org:http://hackage.fpcomplete.com/' > $HOME/.cabal/config
echo 'remote-repo-cache: $HOME/.cabal/packages' >> $HOME/.cabal/config
install:
- echo "$(ghc --version) [$(ghc --print-project-git-commit-id 2> /dev/null || echo '?')]"
- if [ -f configure.ac ]; then autoreconf -i; fi
- |
set -ex
case "$BUILD" in
stack)
# Add in extra-deps for older snapshots, as necessary
#
# This is disabled by default, as relying on the solver like this can
# make builds unreliable. Instead, if you have this situation, it's
# recommended that you maintain multiple stack-lts-X.yaml files.
#stack --no-terminal --install-ghc $ARGS test --bench --dry-run || ( \
# stack --no-terminal $ARGS build cabal-install && \
# stack --no-terminal $ARGS solver --update-config)
# Build the dependencies
stack --no-terminal --install-ghc $ARGS test --bench --only-dependencies
;;
cabal)
cabal --version
travis_retry cabal update
# Get the list of packages from the stack.yaml file. Note that
# this will also implicitly run hpack as necessary to generate
# the .cabal files needed by cabal-install.
PACKAGES=$(stack --install-ghc query locals | grep '^ *path' | sed 's@^ *path:@@')
cabal install --only-dependencies --enable-tests --enable-benchmarks --force-reinstalls --ghc-options=-O0 --reorder-goals --max-backjumps=-1 $CABALARGS $PACKAGES
;;
esac
set +ex
script:
- |
set -ex
case "$BUILD" in
stack)
stack --no-terminal $ARGS test --bench --no-run-benchmarks # --haddock --no-haddock-deps
;;
cabal)
cabal install --enable-tests --enable-benchmarks --force-reinstalls --ghc-options=-O0 --reorder-goals --max-backjumps=-1 $CABALARGS $PACKAGES
ORIGDIR=$(pwd)
for dir in $PACKAGES
do
cd $dir
cabal check || [ "$CABALVER" == "1.16" ]
cabal sdist
PKGVER=$(cabal info . | awk '{print $2;exit}')
SRC_TGZ=$PKGVER.tar.gz
cd dist
tar zxfv "$SRC_TGZ"
cd "$PKGVER"
cabal configure --enable-tests --ghc-options -O0
cabal build
if [ "$CABALVER" = "1.16" ] || [ "$CABALVER" = "1.18" ]; then
cabal test
else
cabal test --show-details=streaming --log=/dev/stdout
fi
cd $ORIGDIR
done
;;
esac
set +ex
- stack --no-terminal $ARGS test --bench --no-run-benchmarks # --haddock --no-haddock-deps
2 changes: 1 addition & 1 deletion chunked-data/package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ extra-source-files:
- ChangeLog.md

dependencies:
- base >= 4.9 && <5
- base >= 4.10 && <5
- transformers
- bytestring >=0.10.2
- text >=1.2
Expand Down
2 changes: 1 addition & 1 deletion classy-prelude-conduit/package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ extra-source-files:
- ChangeLog.md

dependencies:
- base >= 4.9 && <5
- base >= 4.10 && <5
- transformers
- bytestring

Expand Down
2 changes: 1 addition & 1 deletion classy-prelude-yesod/package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ extra-source-files:
- ChangeLog.md

dependencies:
- base >= 4.9 && <5
- base >= 4.10 && <5
- classy-prelude >=1.5.0 && <1.5.1
- classy-prelude-conduit >=1.5.0 && <1.5.1
- yesod >=1.2
Expand Down
2 changes: 1 addition & 1 deletion classy-prelude/package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ extra-source-files:
- ChangeLog.md

dependencies:
- base >= 4.9 && <5
- base >= 4.10 && <5
- transformers
- unordered-containers

Expand Down
2 changes: 1 addition & 1 deletion minlen/package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ extra-source-files:
- ChangeLog.md

dependencies:
- base >= 4.9 && <5
- base >= 4.10 && <5
- mono-traversable
- semigroups
- transformers
Expand Down
2 changes: 1 addition & 1 deletion mono-traversable-instances/package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ extra-source-files:
- ChangeLog.md

dependencies:
- base >= 4.9 && <5
- base >= 4.10 && <5
- mono-traversable >=1.0 && <1.1
- semigroupoids >=3.0
- comonad >=3.0.3
Expand Down
4 changes: 4 additions & 0 deletions mono-traversable/ChangeLog.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 1.0.13.0
* Added `WrappedPoly` to `Data.MonoTraversable`
[#180](https://github.com/snoyberg/mono-traversable/pull/180)

## 1.0.12.0
* Added `filterSet` to `Data.Containers`
* Use container specific implementations for `filterSet` and `filterMap`
Expand Down
4 changes: 2 additions & 2 deletions mono-traversable/package.yaml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: mono-traversable
version: 1.0.12.0
version: 1.0.13.0
synopsis: Type classes for mapping, folding, and traversing monomorphic containers
description: Please see the README at <https://www.stackage.org/package/mono-traversable>
category: Data
Expand All @@ -16,7 +16,7 @@ library:
source-dirs: src
ghc-options: -Wall
dependencies:
- base >= 4.9 && <5
- base >= 4.10 && <5
- containers >=0.5.8
- unordered-containers >=0.2
- hashable
Expand Down
26 changes: 26 additions & 0 deletions mono-traversable/src/Data/MonoTraversable.hs
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
{-# LANGUAGE ConstrainedClassMethods #-}
{-# LANGUAGE CPP #-}
{-# LANGUAGE DefaultSignatures #-}
{-# LANGUAGE DerivingStrategies #-}
{-# LANGUAGE FlexibleContexts #-}
{-# LANGUAGE FlexibleInstances #-}
{-# LANGUAGE TypeFamilies #-}
{-# LANGUAGE TypeOperators #-}
{-# LANGUAGE UndecidableInstances #-}
{-# LANGUAGE GeneralizedNewtypeDeriving #-}
-- | Type classes mirroring standard typeclasses, but working with monomorphic containers.
--
-- The motivation is that some commonly used data types (i.e., 'ByteString' and
Expand Down Expand Up @@ -1382,3 +1384,27 @@ ointercalate x = mconcat . List.intersperse x . otoList
ointercalate x = T.intercalate x . otoList #-}
{-# RULES "intercalate LText" forall x.
ointercalate x = TL.intercalate x . otoList #-}

-- | Provides a `MonoFoldable`, `MonoFunctor` or `MonoPointed` for an arbitrary
-- `F.Foldable`, `Functor` or `Applicative`.
--
-- Useful for, e.g., passing a `F.Foldable` type you don't own into a
-- function that expects a `MonoFoldable`.
--
-- > // package A
-- > data MyList a = MyList [a] deriving Foldable
-- >
-- > // package B
-- > process :: MonoFoldable mono => mono -> IO ()
-- >
-- > // package C
-- > process (WrappedPoly (MyList []))
--
-- @since 1.0.13.0
newtype WrappedPoly f a = WrappedPoly { unwrapPoly :: f a }
deriving newtype (F.Foldable, Functor, Applicative, Monad)

type instance Element (WrappedPoly f a) = a
instance F.Foldable f => MonoFoldable (WrappedPoly f a)
instance Functor f => MonoFunctor (WrappedPoly f a)
instance Applicative f => MonoPointed (WrappedPoly f a)
2 changes: 1 addition & 1 deletion mutable-containers/package.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ extra-source-files:
- ChangeLog.md

dependencies:
- base >= 4.9 && <5
- base >= 4.10 && <5
- containers
- vector

Expand Down
23 changes: 0 additions & 23 deletions stack-lts-9.yaml

This file was deleted.

Loading

0 comments on commit e71e18b

Please sign in to comment.