Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Travis with Github Actions for CI/CD (closes #117) #121

Merged
merged 1 commit into from
Sep 13, 2021

Conversation

mscwilson
Copy link
Contributor

Tests against a variety of Rubies using setup-ruby action, and publishes to RubyGems if a commit is tagged with the correct release version. Tests failed when using Ruby 2.0.

Uses Coveralls action for test coverage. I followed this solution to set up Simplecov for Coveralls.

@mscwilson mscwilson marked this pull request as draft September 8, 2021 10:43
@mscwilson mscwilson marked this pull request as ready for review September 8, 2021 10:55
@mscwilson
Copy link
Contributor Author

As I mentioned here, the Gemfile.lock is not being committed at the moment. We would need to add some extra config for the test matrix to include it. But perhaps this could be its own Issue to consider.

Copy link
Contributor

@paulboocock paulboocock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I only have two comments:

  1. Add a Github Release to the publish step (or a new release step). e.g. https://github.com/snowplow-incubator/snowplow-react-native-tracker/blob/master/.github/workflows/deploy.yml#L186
  2. Split the ruby.yml into two workflows, test.yml and deploy.yml - this creates a better separation, although it does create some duplication. It allows the on to be more specific for each, rather than relying on the if statements which are a little hidden. I'm not too fussed though, both approaches work fine.

@mscwilson mscwilson merged commit df9f07e into release/0.7.0 Sep 13, 2021
@mscwilson mscwilson deleted the gh-actions branch September 13, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants