Add TypeScript definitions to "package.json" for "react-native-tracker" #1450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. Is this your first contribution to a Snowplow open source project? Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://docs.snowplowanalytics.com/docs/contributing/contributor-license-agreement/ to learn more and sign. Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks. |
snowplowcla
added
the
cla:no
Contributor
Author
|
I signed it! |
|
Confirmed! @nelyousfi has signed the Contributor License Agreement. Thanks so much. |
snowplowcla
added
cla:yes
matus-tomlein
approved these changes
Oct 7, 2025
Contributor
matus-tomlein
left a comment
matus-tomlein
left a comment
There was a problem hiding this comment.
LGTM! Thank you for the contribution!
matus-tomlein
changed the base branch from
release/4.6.7
to
fix/react_native_tracker_types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When importing
@snowplow/react-native-tracker, we got the following error:Changing the "moduleResolution" to "node16" fixes this issue, but breaks part of our build pipeline.
Similar issue:
snowplow/snowplow-react-native-tracker#217
Proposed Solution:
This PR makes sure to add support for other module types.