New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`*_tstamp` type definitions should be `string` and not `number` #30

Closed

yinshanyang opened this issue Aug 6, 2021 · 0 comments · Fixed by #33

Assignees

yinshanyang commented Aug 6, 2021

The type definitions for timestamp values, i.e. *_tstamp, are currently number, where as they should be string. It is evident in the snapshot at https://github.com/snowplow-incubator/snowplow-js-analytics-sdk/blob/master/src/__snapshots__/index.spec.ts.snap

The text was updated successfully, but these errors were encountered:

dokmic self-assigned this

dokmic added a commit that referenced this issue


          Fix timestamp fields types (closes #30)

8c1668f

dokmic mentioned this issue

Fix timestamp fields types #33

Merged

dokmic added a commit that referenced this issue


          Fix timestamp fields types (closes #30)

c207504

dokmic added a commit that referenced this issue


          Fix timestamp fields types (closes #30)

bcdd63a

dokmic closed this as completed in

debfc8b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment