-
Notifications
You must be signed in to change notification settings - Fork 132
SNOW-543851: introduce skip label #3415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
SNOW-543851: introduce skip label #3415
Conversation
130d82b
to
ae8c0b5
Compare
9e7d9d4
to
ae8c0b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a lot of boilerplate added to each of the test steps. You could skip it at the top level by doing something similar to the local testing check:
if: ${{!contains(toJSON(github.event.pull_request.requested_teams), 'local-testing')}} |
That doesn't let you have as nice of a message though.
@sfc-gh-jrose skip the test is not enough.. there are required merge gates, and skipping tests can't pass required merge gate, let me check if there are other ways to simplify the code change |
only run required tests |
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-543851
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
introduce 4 skip labels to allow skipping tests
runnings are triggered by label edit/ pr/ commit