Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1791051: Add support for iceberg to dynamic table create #2614

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

sfc-gh-jrose
Copy link
Contributor

@sfc-gh-jrose sfc-gh-jrose commented Nov 12, 2024

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1791051

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.
    • I acknowledge that I have ensured my changes to be thread-safe. Follow the link for more information: Thread-safe Developer Guidelines
  3. Please describe how your code solves the related issue.

This change allows iceberg configuration to be passed to create_or_replace_dynamic_table in the same way that it is passable to save_as_table.

@sfc-gh-jrose sfc-gh-jrose marked this pull request as ready for review November 13, 2024 01:24
@sfc-gh-jrose sfc-gh-jrose requested review from a team as code owners November 13, 2024 01:24
@sfc-gh-jrose sfc-gh-jrose merged commit 819443b into main Nov 14, 2024
37 checks passed
@sfc-gh-jrose sfc-gh-jrose deleted the jrose_snow_1791051_dynamic_iceberg_tables branch November 14, 2024 00:32
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants