SNOW-1163211: Refactor StringType to allow variable max size #1871
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-1163211
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
This PR prepares snowpark for a future change to handling large objects. This mainly affects binary and string columns. Our current snowpark binary type columns do not have a concept for size so will be unaffected by this change. String type columns on the other had need to be made aware of the new max size. To implement support for this I have done the following:
VARCHAR_AND_BINARY_MAX_SIZE_IN_RESULT
parameter that is returned on successful connection of a session. This parameter is not always set so if it is missing we will default to the previous max string size of 16mb. Local testing connections will remain on the old max size for now.