SNOW-3559506: Fix RequestsDependencyWarning from vendored requests with chardet 7.x / charset-normalizer 3.x (#2883) - #2980
Open
Niivii wants to merge 2 commits into
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
|
I have read the CLA Document and I hereby sign the CLA |
sfc-gh-turbaszek
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes SNOW-3559506: RequestsDependencyWarning from vendored requests with chardet 7.x / charset-normalizer 3.x #2883
Related SNOW-628192: RequestsDependencyWarning #1188
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Remove the upper bounds in
check_compatibility()and keep only the minimum-supported-version checks:chardet:>= 3.0.2(was>= 3.0.2, < 6.0.0)charset_normalizer:>= 2.0.0(was>= 2.0.0, < 4.0.0)Dropping the upper bound avoids re-introducing this warning every time a new major version of either dependency is released, as recommended in https://iscinumpy.dev/post/bound-version-constraints/. Imho this is the correct way as this produces false alarms on perfectly working setups which trains people to ignore the warning entirely... Arguably worse than no check. Also the bound never actually protects against anything because chardet/charset_normalizer are already imported before the check runs. So even with breaking API change, the connector would break wether the warning fired or not.
Verified
check_compatibility()in isolation.(Optional) PR for stored-proc connector: