Skip to content

SNOW-3559506: Fix RequestsDependencyWarning from vendored requests with chardet 7.x / charset-normalizer 3.x (#2883) - #2980

Open
Niivii wants to merge 2 commits into
snowflakedb:mainfrom
Niivii:SNOW-3559506-RequestsDependencyWarning
Open

SNOW-3559506: Fix RequestsDependencyWarning from vendored requests with chardet 7.x / charset-normalizer 3.x (#2883)#2980
Niivii wants to merge 2 commits into
snowflakedb:mainfrom
Niivii:SNOW-3559506-RequestsDependencyWarning

Conversation

@Niivii

@Niivii Niivii commented Jul 29, 2026

Copy link
Copy Markdown

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-3559506: RequestsDependencyWarning from vendored requests with chardet 7.x / charset-normalizer 3.x #2883
    Related SNOW-628192: RequestsDependencyWarning #1188

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    Remove the upper bounds in check_compatibility() and keep only the minimum-supported-version checks:

    • chardet: >= 3.0.2 (was >= 3.0.2, < 6.0.0)
    • charset_normalizer: >= 2.0.0 (was >= 2.0.0, < 4.0.0)

    Dropping the upper bound avoids re-introducing this warning every time a new major version of either dependency is released, as recommended in https://iscinumpy.dev/post/bound-version-constraints/. Imho this is the correct way as this produces false alarms on perfectly working setups which trains people to ignore the warning entirely... Arguably worse than no check. Also the bound never actually protects against anything because chardet/charset_normalizer are already imported before the check runs. So even with breaking API change, the connector would break wether the warning fired or not.

    Verified check_compatibility() in isolation.

  4. (Optional) PR for stored-proc connector:

@Niivii
Niivii requested a review from a team as a code owner July 29, 2026 12:25
@github-actions

github-actions Bot commented Jul 29, 2026

Copy link
Copy Markdown

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@Niivii

Niivii commented Jul 29, 2026

Copy link
Copy Markdown
Author

I have read the CLA Document and I hereby sign the CLA

1 similar comment
@vleemrijse

Copy link
Copy Markdown

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SNOW-3559506: RequestsDependencyWarning from vendored requests with chardet 7.x / charset-normalizer 3.x

3 participants