fix: avoid duplicating trailing semicolons in executemany - #2854
Open
BlocksecPHD wants to merge 1 commit into
Open
fix: avoid duplicating trailing semicolons in executemany#2854BlocksecPHD wants to merge 1 commit into
BlocksecPHD wants to merge 1 commit into
Conversation
|
I have read the CLA Document and I hereby sign the CLA Funan Zhou seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
sfc-gh-turbaszek
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2853
Pre-review checklist
Summary
This fixes the
executemany(..., num_statements=...)semicolon handling in both sync and async cursors.The current code uses
re.search(";/s*$", command), which never matches trailing whitespace after a semicolon because/sis treated literally instead of as\\s. As a result, commands that already end with;can still receive an extra;during multi-statement concatenation.This change replaces that check with
not command.endswith(";").executemanyalready normalizes the command withcommand.strip(" \\t\\n\\r")before this branch, soendswith(";")correctly handles the intended trailing-whitespace cases without regex.Tests
python3 -m pytest test/unit/test_cursor.py test/unit/aio/test_cursor_async_unit.py -k trailing_semicolon -q