Skip to content

Conversation

sfc-gh-pczajka
Copy link
Collaborator

@sfc-gh-pczajka sfc-gh-pczajka commented Sep 17, 2025

Cherry picks to aio-connector:


Commits applied without changes:


@sfc-gh-pczajka sfc-gh-pczajka marked this pull request as draft September 17, 2025 12:04
Copy link

github-actions bot commented Sep 17, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


5 out of 6 committers have signed the CLA.
✅ (sfc-gh-fpawlowski)[https://github.com/sfc-gh-fpawlowski]
✅ (sfc-gh-pczajka)[https://github.com/sfc-gh-pczajka]
✅ (sfc-gh-saroskar)[https://github.com/sfc-gh-saroskar]
✅ (sfc-gh-mmishchenko)[https://github.com/sfc-gh-mmishchenko]
✅ (sfc-gh-pcyrek)[https://github.com/sfc-gh-pcyrek]
@sfc-gh-mborins
You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@sfc-gh-pczajka sfc-gh-pczajka marked this pull request as ready for review September 17, 2025 14:32
@sfc-gh-pczajka sfc-gh-pczajka force-pushed the cherrypicks-to-aio-connector-part17 branch from 1ca8abb to 5f46970 Compare September 24, 2025 10:51
)
elif self._authenticator == PROGRAMMATIC_ACCESS_TOKEN:
self.auth_class = AuthByPAT(self._token)
elif self._authenticator == PAT_WITH_EXTERNAL_SESSION:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: This may be a low hanging fruit for the future - to at least fallback to synch code.

)
elif self._authenticator == PROGRAMMATIC_ACCESS_TOKEN:
self.auth_class = AuthByPAT(self._token)
elif self._authenticator == PAT_WITH_EXTERNAL_SESSION:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also user will now end up using AuthByOkta (in else block) since there is no match for PAT with external session in async. Do we want better info, or to stay with this one?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sfc-gh-pczajka sfc-gh-pczajka merged commit e773c49 into dev/aio-connector Sep 25, 2025
44 of 53 checks passed
@sfc-gh-pczajka sfc-gh-pczajka deleted the cherrypicks-to-aio-connector-part17 branch September 25, 2025 15:45
@github-actions github-actions bot locked and limited conversation to collaborators Sep 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants