-
Notifications
You must be signed in to change notification settings - Fork 522
Cherrypicks to aio connector part17 #2540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherrypicks to aio connector part17 #2540
Conversation
The trailing slash breaks the OAUTH_AUTHORIZATION_CODE flow for LOCAL_APPLICATION. Removing this trailing slash enables the flow to work properly.
I have read the CLA Document and I hereby sign the CLA 5 out of 6 committers have signed the CLA. |
1ca8abb
to
5f46970
Compare
) | ||
elif self._authenticator == PROGRAMMATIC_ACCESS_TOKEN: | ||
self.auth_class = AuthByPAT(self._token) | ||
elif self._authenticator == PAT_WITH_EXTERNAL_SESSION: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: This may be a low hanging fruit for the future - to at least fallback to synch code.
) | ||
elif self._authenticator == PROGRAMMATIC_ACCESS_TOKEN: | ||
self.auth_class = AuthByPAT(self._token) | ||
elif self._authenticator == PAT_WITH_EXTERNAL_SESSION: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also user will now end up using AuthByOkta (in else block) since there is no match for PAT with external session in async. Do we want better info, or to stay with this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cherry picks to aio-connector:
Commits applied without changes: