Skip to content

Isolate connection name loading tests #2515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2025
Merged

Isolate connection name loading tests #2515

merged 1 commit into from
Sep 1, 2025

Conversation

@sfc-gh-pczajka
Copy link
Collaborator

@sfc-gh-pczajka sfc-gh-pczajka commented Sep 1, 2025

This PR fixes two issues with test_*_name_loading_test tests:

  1. The test used SF_CONNECIONS variable, which was a hacky way of overriding [connections] section of config.toml file - the variable was corrected to SNOWFLAKE_CONNECTIONS
  2. Only connection name used in test was "default", which caused us to miss above error

@sfc-gh-pczajka sfc-gh-pczajka requested a review from a team as a code owner September 1, 2025 12:00
@sfc-gh-pczajka sfc-gh-pczajka added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Sep 1, 2025
@sfc-gh-pczajka sfc-gh-pczajka enabled auto-merge (squash) September 1, 2025 12:01
sfc-gh-fpawlowski
sfc-gh-fpawlowski approved these changes Sep 1, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-fpawlowski sfc-gh-fpawlowski left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well caught, lgtm

sfc-gh-pczajka added a commit that referenced this pull request Sep 1, 2025
@sfc-gh-pczajka
cherry-pick #2515
2466437
sfc-gh-pczajka added a commit that referenced this pull request Sep 1, 2025
@sfc-gh-pczajka
Apply #2515 to async code
bcd1399
@sfc-gh-pczajka sfc-gh-pczajka merged commit 2542058 into main Sep 1, 2025
82 of 102 checks passed
@sfc-gh-pczajka sfc-gh-pczajka deleted the isolate-connection-name-loading-test branch September 1, 2025 12:19
@github-actions github-actions bot locked and limited conversation to collaborators Sep 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-fpawlowski sfc-gh-fpawlowski sfc-gh-fpawlowski approved these changes

Assignees

No one assigned

Labels

DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sfc-gh-pczajka @sfc-gh-fpawlowski