Skip to content

Update WIF integration tests to verify authenticated username + prepare for impersonation #2510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 29, 2025
Merged

Update WIF integration tests to verify authenticated username + prepare for impersonation #2510

merged 6 commits into from
Aug 29, 2025

Conversation

@sfc-gh-pmansour
Copy link
Contributor

@sfc-gh-pmansour sfc-gh-pmansour commented Aug 27, 2025

  • Explicitly verify authenticated user name
  • Add WIF integration test for impersonation
  • Update corresponding configs / scripts

Most of this is in preparation for impersonation support (#2496).

@sfc-gh-pmansour
- Verify expected user in WIF integration tests
d2c615d 
- Add WIF integration test for impersonation
- Update configs / scripts
@sfc-gh-pmansour sfc-gh-pmansour requested a review from a team as a code owner August 27, 2025 16:37
@sfc-gh-pmansour sfc-gh-pmansour added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Aug 27, 2025
@sfc-gh-pmansour sfc-gh-pmansour mentioned this pull request Aug 27, 2025
Merged
7 tasks
@sfc-gh-eqin sfc-gh-eqin force-pushed the pmansour/verify-users-in-wif-integration-test branch from 2f8a800 to d2c615d Compare August 27, 2025 18:26
@sfc-gh-eqin Graphite App
Copy link
Contributor

sfc-gh-eqin commented Aug 27, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

sfc-gh-eqin
sfc-gh-eqin approved these changes Aug 28, 2025
View reviewed changes
@sfc-gh-pmansour
Copy link
Contributor Author

sfc-gh-pmansour commented Aug 28, 2025 •
edited
Loading

Most tests pass, but there are some unrelated failures:

  • Jenkins jobs are failing to build in Python 3.9 due to some wheel-related issues.
  • Some web browser login tests are timing out.

Given these are unrelated, I'll mark this as "auto-merge" once we have an approval from the drivers team.

@sfc-gh-pmansour sfc-gh-pmansour enabled auto-merge (squash) August 28, 2025 22:39
@sfc-gh-pmansour sfc-gh-pmansour merged commit 87d600a into main Aug 29, 2025
91 of 99 checks passed
@sfc-gh-pmansour sfc-gh-pmansour deleted the pmansour/verify-users-in-wif-integration-test branch August 29, 2025 07:37
@github-actions github-actions bot locked and limited conversation to collaborators Aug 29, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk approved these changes

@sfc-gh-eqin sfc-gh-eqin sfc-gh-eqin approved these changes

@sfc-gh-mmishchenko sfc-gh-mmishchenko Awaiting requested review from sfc-gh-mmishchenko

Assignees

No one assigned

Labels

DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sfc-gh-pmansour @sfc-gh-eqin @sfc-gh-akolodziejczyk