-
Notifications
You must be signed in to change notification settings - Fork 527
SNOW-2226057: GH Actions moved to key-pair, old driver bump to 3.1.0 #2432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-akolodziejczyk
approved these changes
Jul 29, 2025
Co-authored-by: Maxim Mishchenko <maxim.mishchenko@snowflake.com>
sfc-gh-mmishchenko
approved these changes
Aug 5, 2025
Comment on lines
-1211
to
-1219
| @pytest.mark.external | ||
| def test_client_failover_connection_url(conn_cnx): | ||
| with conn_cnx("client_failover") as conn: | ||
| with conn.cursor() as cur: | ||
| assert cur.execute("select 1;").fetchall() == [ | ||
| (1,), | ||
| ] | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this test was removed?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
DO_NOT_PORT_CHANGES_TO_SP
Add this label when changes in this PR do not need to be port to SP connector
NO-CHANGELOG-UPDATES
This pull request does not need to update CHANGELOG.md
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please answer these questions before submitting your pull requests. Thanks!
SNOW-2226057: GH Actions moved to key-pair, old driver bump to 3.1.0
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
(Optional) PR for stored-proc connector: