Skip to content

Conversation

@sfc-gh-pcyrek
Copy link
Contributor

@sfc-gh-pcyrek sfc-gh-pcyrek commented Jul 25, 2025

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

SNOW-2226057: GH Actions moved to key-pair, old driver bump to 3.1.0

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  3. (Optional) PR for stored-proc connector:

@sfc-gh-pcyrek sfc-gh-pcyrek changed the title SNOW-2226057: moving to key-pair SNOW-2226057: GH Actions moved to key-pair, old driver bump to 3.1.0 Jul 28, 2025
@sfc-gh-pcyrek sfc-gh-pcyrek merged commit a269f15 into main Aug 6, 2025
88 of 96 checks passed
@sfc-gh-pcyrek sfc-gh-pcyrek deleted the SNOW-2226057-moving-driver-to-key-pair branch August 6, 2025 10:47
@github-actions github-actions bot locked and limited conversation to collaborators Aug 6, 2025
Comment on lines -1211 to -1219
@pytest.mark.external
def test_client_failover_connection_url(conn_cnx):
with conn_cnx("client_failover") as conn:
with conn.cursor() as cur:
assert cur.execute("select 1;").fetchall() == [
(1,),
]


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this test was removed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants