-
Notifications
You must be signed in to change notification settings - Fork 527
SNOW-2171791: Add platform telemetry #2387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
sfc-gh-sshetkar
merged 60 commits into
main
from
sshetkar-SNOW-2171791-add-platform-telemetry
Aug 4, 2025
Merged
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
3e3d732
added telemetry emission for AWS Lambda, AWS EC2, Azure VM, GCE VM, a…
sfc-gh-sshetkar 0d6683b
added github action platform check
sfc-gh-sshetkar f7879bd
linter fixes
sfc-gh-sshetkar 2e5168f
added checks for managed identity
sfc-gh-sshetkar a8ad08d
put telemetry on a separate thread since it makes some network calls …
sfc-gh-sshetkar ce185da
added check for aws identity and refactored ec2 check to use AWS library
sfc-gh-sshetkar b1734ec
updated name for aws arn identity check function
sfc-gh-sshetkar 99f4bf8
added gcp identity checks and updated AWS checks to do generic except…
sfc-gh-sshetkar c66c054
updated azure managed identity check to go against the default snowfl…
sfc-gh-sshetkar d62e955
switched to 0.5 second timeout because eventually it won't be run on …
sfc-gh-sshetkar 44ac14c
changed to return list of signals instead of dictionary of true and f…
sfc-gh-sshetkar d163d32
switched to detect platforms by adding it to the base_auth data which…
sfc-gh-sshetkar 69c637e
changed gcp identity check to be 0.5 seconds for timeout
sfc-gh-sshetkar 87668c6
Merge branch 'main' into sshetkar-SNOW-2171791-add-platform-telemetry
sfc-gh-sshetkar fb4ccf7
Merge branch 'main' into sshetkar-SNOW-2171791-add-platform-telemetry
sfc-gh-sshetkar 7a527ab
added unit tests for detecting platforms
sfc-gh-sshetkar fc611be
refactored platform detection to it's own file and updates unit tests
sfc-gh-sshetkar 48e0541
updated unit tests
sfc-gh-sshetkar 2394414
mocked detect_platform in connection tests to not affect the tests in…
sfc-gh-sshetkar 0963b72
Merge branch 'main' into sshetkar-SNOW-2171791-add-platform-telemetry
sfc-gh-sshetkar 4467c00
changed to 200 millisecond timeout
sfc-gh-sshetkar bfb4b67
skip test_auth_mfa on windows since it runs inconsistently on that OS
sfc-gh-sshetkar f0dd5c7
added parameter for timeout that user can configure
sfc-gh-sshetkar 0d347d4
added None type to detect_platforms so it gives correct type hinting
sfc-gh-sshetkar bd7082a
added timeout signals, added parameter for user to be able control ti…
sfc-gh-sshetkar bff44f1
added getter and setter for new platform detection timeout field
sfc-gh-sshetkar ec63ad0
Merge branch 'main' into sshetkar-SNOW-2171791-add-platform-telemetry
sfc-gh-sshetkar 76fa99c
make sure platform timeout detection is mocked
sfc-gh-sshetkar c9577da
put the skip old driver on my test instead of the other test_bad_db test
sfc-gh-sshetkar e5590a7
Merge branch 'main' into sshetkar-SNOW-2171791-add-platform-telemetry
sfc-gh-mmishchenko bee50ef
added doc comments for every function in the detect platform module
sfc-gh-sshetkar 30b037c
updated client side parameter to include units. changed to only use f…
sfc-gh-sshetkar 2b74108
added functools.cache on platform detection since results are not sup…
sfc-gh-sshetkar 520fa2e
changed resource for azure vm so that it could work in all scenarios …
sfc-gh-sshetkar 2d42ed4
changed to compare against status code for gcp identity instead of te…
sfc-gh-sshetkar e2b6a32
removed the extraneous else if statement for NOT_DETECT since we don'…
sfc-gh-sshetkar 06f94cb
chanaged azure managed identity check to not depend on previous check…
sfc-gh-sshetkar 9710ce2
add try except clause on the detect_platform so that no exceptions le…
sfc-gh-sshetkar 7917c0d
clear cache after every test run. used actual response class to avoid…
sfc-gh-sshetkar 971a0bd
updated tests and csphelpers to use consistent mock enviornments with…
sfc-gh-sshetkar 8e79c1d
added parameterized test for testing valid aws arn identities
sfc-gh-sshetkar 527efd9
added negative tests
sfc-gh-sshetkar 6b7a1a2
Merge branch 'main' into sshetkar-SNOW-2171791-add-platform-telemetry
sfc-gh-sshetkar a2c4049
added yield so cache clearing happens after every test
sfc-gh-sshetkar c27b8ec
updated os dictionary patching so it shouldn't use the actual OS envi…
sfc-gh-sshetkar 787ffe7
updated parameter name injected in connection integration test
sfc-gh-sshetkar c082f40
removed caching off the function to test if that is what is causing f…
sfc-gh-sshetkar fe14cd8
patched os dictionary so that is clears it before every test and then…
sfc-gh-sshetkar 3e16e1c
added caching back in to see if it runs on github actions tests
sfc-gh-sshetkar e7995a6
make test run serially to avoid caching issue and clear cache before …
sfc-gh-sshetkar a8085f7
addressed comments related to fixed comments, optimizing platform det…
sfc-gh-sshetkar f4dcfe6
updated name for has_azure_managed_identity in the signal response
sfc-gh-sshetkar 62c2fad
got rid of BrokenMetadataService and changed to have the base class s…
sfc-gh-sshetkar 5918f5b
updated github to not use fakemetadataservice since it doesn't implem…
sfc-gh-sshetkar c7a238c
updated to separate out AWS lambda as another fake class and used tha…
sfc-gh-sshetkar 2134261
updated fake azure vm with no metadata endpoint to not use weird way …
sfc-gh-sshetkar f3319c5
Merge branch 'main' into sshetkar-SNOW-2171791-add-platform-telemetry
sfc-gh-sshetkar bdacd5c
added check in gce vm check to not throw an exception if headers don'…
sfc-gh-sshetkar 6e3a969
mocked the timeout parallel test properly to match what values of the…
sfc-gh-sshetkar 440dc28
forgot to unpack args parameter on __exit__ for FakeAwsLambdaEnvironment
sfc-gh-sshetkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.