Skip to content

SNOW-1789751: Add GCP regional and virtual endpoints support #2233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 27, 2025
Merged

SNOW-1789751: Add GCP regional and virtual endpoints support #2233

merged 8 commits into from
Mar 27, 2025

Conversation

@sfc-gh-pbulawa
Copy link
Contributor

@sfc-gh-pbulawa sfc-gh-pbulawa commented Mar 25, 2025 •
edited
Loading

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #SNOW-1789751

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Add support for the GCP regional and virtual endpoints

  4. (Optional) PR for stored-proc connector:

@sfc-gh-pbulawa sfc-gh-pbulawa added the DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector label Mar 25, 2025
sfc-gh-zyao
sfc-gh-zyao reviewed Mar 25, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-zyao sfc-gh-zyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Python Stored Proc perspective. And I can confirm that we don't need to port it to SP connector

sfc-gh-mkubik
sfc-gh-mkubik reviewed Mar 27, 2025
View reviewed changes
sfc-gh-mmishchenko
sfc-gh-mmishchenko approved these changes Mar 27, 2025
View reviewed changes
Copy link
Contributor

@sfc-gh-mmishchenko sfc-gh-mmishchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sfc-gh-pbulawa sfc-gh-pbulawa changed the title SNOW-1789751: Add regional endpoints support SNOW-1789751: Add regional and virtual endpoints support Mar 27, 2025
@sfc-gh-pbulawa sfc-gh-pbulawa changed the title SNOW-1789751: Add regional and virtual endpoints support SNOW-1789751: Add GCP regional and virtual endpoints support Mar 27, 2025
@sfc-gh-pbulawa sfc-gh-pbulawa merged commit 253c47a into main Mar 27, 2025
94 checks passed
@sfc-gh-pbulawa sfc-gh-pbulawa deleted the SNOW-1789751-gcp-region-endpoints branch March 27, 2025 15:02
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-zyao sfc-gh-zyao sfc-gh-zyao left review comments

+2 more reviewers

@sfc-gh-mkubik sfc-gh-mkubik sfc-gh-mkubik approved these changes

@sfc-gh-mmishchenko sfc-gh-mmishchenko sfc-gh-mmishchenko approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sfc-gh-pbulawa @sfc-gh-zyao @sfc-gh-mkubik @sfc-gh-mmishchenko