Skip to content

NO-SNOW: Run test when targeting branches other than main #2221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

NO-SNOW: Run test when targeting branches other than main #2221

merged 1 commit into from
Mar 19, 2025

Conversation

@sfc-gh-jszczerbinski
Copy link
Collaborator

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski commented Mar 19, 2025

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-jszczerbinski sfc-gh-jszczerbinski changed the title Run test when targeting other branches than master NO-SNOW: Run test when targeting other branches than main Mar 19, 2025
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Mar 19, 2025
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski changed the title NO-SNOW: Run test when targeting other branches than main NO-SNOW: Run test when targeting branches other than main Mar 19, 2025
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski merged commit da98f2d into main Mar 19, 2025
91 of 98 checks passed
@sfc-gh-jszczerbinski sfc-gh-jszczerbinski deleted the sfc-gh-jszczerbinski-patch-1 branch March 19, 2025 09:50
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

+1 more reviewer

@sfc-gh-mkubik sfc-gh-mkubik sfc-gh-mkubik approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sfc-gh-jszczerbinski @sfc-gh-pbulawa @sfc-gh-pfus @sfc-gh-mkubik