Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1760502 Update README.md #2088

Merged
merged 1 commit into from
Oct 30, 2024
Merged

SNOW-1760502 Update README.md #2088

merged 1 commit into from
Oct 30, 2024

Conversation

sfc-gh-mkeller
Copy link
Collaborator

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1760502

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Just adding a new section to the README.

  4. (Optional) PR for stored-proc connector:

@sfc-gh-mkeller sfc-gh-mkeller added NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector labels Oct 25, 2024
sfc-gh-mfei
sfc-gh-mfei approved these changes Oct 25, 2024
View reviewed changes
Copy link

@sfc-gh-mfei sfc-gh-mfei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-mkeller sfc-gh-mkeller merged commit 41a19e7 into main Oct 30, 2024
95 of 98 checks passed
@sfc-gh-mkeller sfc-gh-mkeller deleted the mkeller/SNOW-1760502-disclaimer branch October 30, 2024 17:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aling sfc-gh-aling sfc-gh-aling approved these changes

@sfc-gh-mfei sfc-gh-mfei sfc-gh-mfei approved these changes

Assignees
No one assigned
Labels
DO_NOT_PORT_CHANGES_TO_SP Add this label when changes in this PR do not need to be port to SP connector NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-mkeller @sfc-gh-aling @sfc-gh-mfei