Skip to content

Conversation

@sfc-gh-sfan
Copy link
Contributor

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-756460

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency
  3. Please describe how your code solves the related issue.

    This job can help us clean up old issues for reprioritization. Will test with a very large staleDays input first.

@sfc-gh-sfan
Copy link
Contributor Author

I'm not sure how to test it without merging it :/

steps:
- uses: actions/stale@v7
with:
close-issue-message: 'To clean up and re-prioritize bugs and feature requests we are closing all issues older than 6 months as of March 1, 2023. If there are any issues or feature requests that you would like us to address, please re-create them. For urgent issues, opening a support case with this link Snowflake Community is the fastest way to get a response'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we specify a date when we run this action?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could only specify days, but not a date :/ There is a date but that is used to ignore issues before a certain date :(

https://github.com/actions/stale#days-before-stale

@codecov-commenter
Copy link

Codecov Report

Merging #1468 (f8116c1) into main (ec95c56) will decrease coverage by 0.06%.
The diff coverage is 83.33%.

❗ Current head f8116c1 differs from pull request most recent head 7876f21. Consider uploading reports for the commit 7876f21 to get more accurate results

@@            Coverage Diff             @@
##             main    #1468      +/-   ##
==========================================
- Coverage   81.91%   81.86%   -0.06%     
==========================================
  Files          60       60              
  Lines        8599     8596       -3     
  Branches     1271     1271              
==========================================
- Hits         7044     7037       -7     
  Misses       1225     1225              
- Partials      330      334       +4     
Impacted Files Coverage Δ
src/snowflake/connector/network.py 82.63% <75.00%> (+2.38%) ⬆️
src/snowflake/connector/cursor.py 94.66% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfc-gh-sfan sfc-gh-sfan merged commit ed4dbdd into main Mar 9, 2023
@sfc-gh-sfan sfc-gh-sfan deleted the shixuan_stale branch March 9, 2023 22:20
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants