Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1756807: Add note about GCP regional endpoints #1051

Merged

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Description

SNOW-1756807

Checklist

  • Code compiles correctly
  • Code is formatted according to Coding Conventions
  • Created tests which fail without the change (if possible)
  • All tests passing (dotnet test)
  • Extended the README / documentation, if necessary
  • Provide JIRA issue id (if possible) or GitHub issue id in PR name

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner October 29, 2024 13:15
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.19%. Comparing base (b21bfb3) to head (077c350).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1051      +/-   ##
==========================================
- Coverage   86.22%   86.19%   -0.03%     
==========================================
  Files         120      120              
  Lines       11628    11628              
  Branches     1167     1167              
==========================================
- Hits        10026    10023       -3     
- Misses       1321     1326       +5     
+ Partials      281      279       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

README.md Outdated Show resolved Hide resolved
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1756807-add-note-about-gcp-regional-endpoints branch from cd5c032 to ce6025c Compare October 30, 2024 07:09
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1756807-add-note-about-gcp-regional-endpoints branch from ce6025c to 077c350 Compare October 30, 2024 07:10
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 5e16693 into master Oct 30, 2024
53 of 54 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1756807-add-note-about-gcp-regional-endpoints branch October 30, 2024 10:12
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants