NOSNOW add a global --color flag to disable colored output#2728
Open
sfc-gh-boler wants to merge 1 commit intomainfrom
Open
NOSNOW add a global --color flag to disable colored output#2728sfc-gh-boler wants to merge 1 commit intomainfrom
sfc-gh-boler wants to merge 1 commit intomainfrom
Conversation
When invoked with `--color=off`, the tool it no longer color its output, other formatting (bold, italics) remains unchanged. Implementation wise, it seems the most robust way to disable colors is to set `NO_COLOR` env, which then works across all other libraries using `rich`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When invoked with
--color=off, the tool it no longer color its output, other formatting (bold, italics) remains unchanged.We opt for a multi state option, so that it's extensible with other behaviours and themes.
Implementation wise, it seems the most robust way to disable colors is to set
NO_COLORenv, which then works across all other libraries usingrich.Pre-review checklist