SNOW-1639914: add bogus user password test #1210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-ext-simba-jl
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1210 +/- ##
=======================================
Coverage 82.60% 82.60%
=======================================
Files 54 54
Lines 12909 12909
=======================================
Hits 10663 10663
Misses 2246 2246 ☔ View full report in Codecov by Sentry. |
sfc-gh-ext-simba-jl
requested review from
sfc-gh-pbulawa,
sfc-gh-dheyman-1 and
sfc-gh-dstempniak
sfc-gh-ext-simba-jl
force-pushed
the
SNOW-1639914-add-bogus-user-password-test
branch
2 times, most recently
from
5e718d2
to
e0ccded
Compare
sfc-gh-dheyman-1
approved these changes
Oct 2, 2024
sfc-gh-pfus
reviewed
Oct 8, 2024
sfc-gh-ext-simba-jl
force-pushed
the
SNOW-1639914-add-bogus-user-password-test
branch
from
e0ccded
to
e04fa0b
Compare
sfc-gh-pfus
approved these changes
Oct 10, 2024
sfc-gh-ext-simba-jl
force-pushed
the
SNOW-1639914-add-bogus-user-password-test
branch
from
a4a11ea
to
78e57b1
Compare
sfc-gh-ext-simba-jl
deleted the
SNOW-1639914-add-bogus-user-password-test
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
teamwork issue 1090: https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/1090
The test
TestBogusUserPasswordParameterswas removed in PR #1194 due to server changes. This PR added the test back but with different expected error.Checklist