SNOW-903604 Zombie dbus processes generated by one of our dependencies github.com/99designs/keyring #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s github.com/99designs/keyring After long consideration and discussion how we want to address the issue we decided to go with only documenting for now, which is what i tried to do here, alongside with trying to detect if the OS is susceptible for the issue (not all Linux are) If so, log a warning of the issue + workaround which is the same as documented in the README now. Of course this is by no means a solution - long term solution will be to replace the current keyring implementation.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1058 +/- ##
==========================================
- Coverage 84.12% 83.97% -0.15%
==========================================
Files 50 50
Lines 9889 9918 +29
==========================================
+ Hits 8319 8329 +10
- Misses 1570 1589 +19 ☔ View full report in Codecov by Sentry. |
sfc-gh-pfus
reviewed
Mar 4, 2024
sfc-gh-pfus
approved these changes
Mar 4, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SNOW-903604 Zombie dbus processes generated by one of our dependencies github.com/99designs/keyring
After long consideration and discussion how we want to address the issue we decided to go with only documenting for now, which is what i tried to do here, alongside with trying to detect if the OS is susceptible for the issue (not all Linux are)
If so, log a warning of the issue + workaround which is the same as documented in the README now.
Of course this is by no means a solution - long term solution will be to possibly replace the current keyring implementation.
Description
Please explain the changes you made here.
Checklist
make fmtto fix inconsistent formatsmake lintto get lint errors and fix all of them