Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce singleton API client with retry policy #130

Merged
merged 6 commits into from
May 18, 2020
Merged

Introduce singleton API client with retry policy #130

merged 6 commits into from
May 18, 2020

Conversation

snobu
Copy link
Owner

@snobu snobu commented May 14, 2020

  • Introduce singleton API client with retry policy
  • Remove all refresh token logic. Turns out the cookie we got back from /refreshtoken didn't do shit. And by that i mean its expiration date wasn't extended.

@snobu snobu requested review from kylon and lukaarma May 14, 2020 21:21
@snobu
Copy link
Owner Author

snobu commented May 18, 2020

Merging this without code review because YOLO.

@snobu snobu merged commit 2c48d10 into master May 18, 2020
@snobu snobu mentioned this pull request May 18, 2020
Closed
@snobu snobu deleted the apiclient branch May 19, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylon kylon Awaiting requested review from kylon

@lukaarma lukaarma Awaiting requested review from lukaarma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@snobu