Skip to content

clone: support for creating additional disks #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

michaelw
Copy link

Option "--disks 32 64" adds two additional disks, 32GB and 64GB.

@snobear
Copy link
Owner

snobear commented Jul 19, 2016

@michaelw great addition, thanks. Per the arg description:

...
        help="Additional disks in GB, e.g. 16,thin 32; "
             "adds two disks, 16GB (thin provisioned) and 32GB (default)",
        nargs="+",
...

shouldn't that say e.g. --disk 16 thin 32 ?

Also can you fix the pep8 errors per the Travis build?

@michaelw michaelw force-pushed the mw/disks branch 3 times, most recently from 5a16916 to c92d281 Compare July 21, 2016 06:53
@michaelw
Copy link
Author

updated.

re the example, --disks SPEC1 SPEC2, where SPECi consists of SIZE,FLAGS... is easier to extend in the future, if needed.

Option "--disks 32 64" adds two additional disks, 32GB and 64GB.
@snobear snobear merged commit a8ba60c into snobear:master Sep 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants