Avoid redefining future.utils.text_type #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienball
requested changes
Apr 23, 2019
snips_nlu/common/utils.py
Outdated
| @@ -10,7 +10,7 @@ | |||
|
|
|||
| import numpy as np | |||
| import pkg_resources | |||
| from future.utils import PY3 | |||
| from future.utils import PY3, text_type | |||
There was a problem hiding this comment.
Can you remove the PY3 import as it is no longer required?
Codecov Report
@@ Coverage Diff @@
## develop #786 +/- ##
===========================================
- Coverage 88.23% 88.17% -0.06%
===========================================
Files 76 76
Lines 4537 4534 -3
Branches 868 867 -1
===========================================
- Hits 4003 3998 -5
- Misses 400 401 +1
- Partials 134 135 +1 |
adrienball
approved these changes
Apr 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Checklist: