Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve failed linking error message after download of resources #774

Merged
merged 2 commits into from
Mar 25, 2019

Conversation

adrienball
Copy link
Contributor

Description:
This avoids silencing underlying symbolic linking errors.

Checklist:

  • My PR is ready for code review
  • I have added some tests, if applicable, and run the whole test suite, including linting tests
  • I have updated the documentation, if applicable

@codecov-io
Copy link

codecov-io commented Mar 22, 2019

Codecov Report

Merging #774 into develop will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           develop     #774   +/-   ##
========================================
  Coverage    88.02%   88.02%           
========================================
  Files           76       76           
  Lines         4491     4491           
  Branches       853      853           
========================================
  Hits          3953     3953           
  Misses         402      402           
  Partials       136      136

@adrienball adrienball changed the title Raise error when linking fails after download of resources Improve failed linking error message after download of resources Mar 22, 2019
@adrienball adrienball merged commit 760c278 into develop Mar 25, 2019
@adrienball adrienball deleted the task/improve-download-cli branch March 25, 2019 10:09
@adrienball adrienball mentioned this pull request Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants