-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Windows file path and general minor fixes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
SteveMattar
commented
Dec 27, 2022
- Deal with file paths on Windows
- Avoid missing glyph columns
- fix buttons naming
Signed-off-by: Steve Mattar <Steve.Mattar@skai.io>
Signed-off-by: Steve Mattar <Steve.Mattar@skai.io>
Signed-off-by: Steve Mattar <Steve.Mattar@skai.io>
SteveMattar
force-pushed
the
general_fixes
branch
from
December 27, 2022 11:58
630cf64
to
97e3f82
Compare
I got this error running the test files: python3 -m pytest
========================== test session starts ==========================
platform darwin -- Python 3.10.6, pytest-7.1.3, pluggy-1.0.0
rootdir: /Users/xxx/work/gt7telemetry
collected 21 items
test_gt7communication.py ss [ 9%]
test_gt7helper.py ..F................ [100%]
=============================== FAILURES ================================
______ TestHelper.test_calculate_time_diff_by_distance_from_pickle ______
self = <test_gt7helper.TestHelper testMethod=test_calculate_time_diff_by_distance_from_pickle>
def test_calculate_time_diff_by_distance_from_pickle(self):
path = os.path.join(os.path.abspath(__file__), 'test_data', 'tsukuba_2laps_rain_first_is_best.pickle')
> laps = gt7helper.load_laps_from_pickle(path)
test_gt7helper.py:81:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
path = '/Users/xxx/work/gt7telemetry/test_gt7helper.py/test_data/tsukuba_2laps_rain_first_is_best.pickle'
def load_laps_from_pickle(path: str) -> List[Lap]:
> with open(path, "rb") as f:
E NotADirectoryError: [Errno 20] Not a directory: '/Users/xxx/work/gt7telemetry/test_gt7helper.py/test_data/tsukuba_2laps_rain_first_is_best.pickle'
gt7helper.py:323: NotADirectoryError
=========================== warnings summary ============================
../../../../usr/local/lib/python3.10/site-packages/salsa20.py:11
/usr/local/lib/python3.10/site-packages/salsa20.py:11: DeprecationWarning: the imp module is deprecated in favour of importlib and slated for removal in Python 3.12; see the module's documentation for alternative uses
import imp
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
======================== short test summary info ========================
FAILED test_gt7helper.py::TestHelper::test_calculate_time_diff_by_distance_from_pickle
========== 1 failed, 18 passed, 2 skipped, 1 warning in 2.26s ===========
make: *** [test] Error 1 |
Here is the same error in the workflow: https://github.com/SteveMattar/gt7dashboard/actions/runs/4276463317/jobs/7444570299#step:5:46 |
Hey, sorry for seeing your message just now. Did you manage to fix it?
|
Yes I fixed it 3a7bfde |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.