Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #8482 - Ubuntu version #8598

Merged
merged 3 commits into from
Nov 17, 2020
Merged

Fixed #8482 - Ubuntu version #8598

merged 3 commits into from
Nov 17, 2020

Conversation

chamilton-ccn
Copy link
Contributor

@chamilton-ccn chamilton-ccn commented Oct 23, 2020

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context, providing screenshots where practical. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Successfully ran install script after making the proposed change.

musashiXXX and others added 3 commits October 23, 2020 08:45
…n addresses issue #8482 and retains the intended function of the previous code.
…n addresses issue #8482 and retains the intended function of the previous code.
@welcome
Copy link

welcome bot commented Oct 23, 2020

💖 Thanks for this pull request! 💖

We use semantic commit messages to streamline the release process and easily generate changelogs between versions. Before your pull request can be merged, you should update your pull request title to start with a semantic prefix if it doesn't have one already.

Examples of commit messages with semantic prefixes:

  • Fixed #<issue number>: don't overwrite prevent_default if default wasn't prevented
  • Added #<issue number>: add checkout functionality to assets
  • Improved Asset Checkout: use new notification method for checkout

Things that will help get your PR across the finish line:

  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@snipe snipe changed the title This pull request addresses issue #8482 and retains the intended function of the previous code. Fixed #8482 - Ubuntu version Oct 23, 2020
@snipe snipe requested a review from uberbrady October 23, 2020 21:17
@snipe
Copy link
Owner

snipe commented Nov 17, 2020

@uberbrady can you take a look at this (very small) PR and sanity check for me?

@uberbrady
Copy link
Collaborator

I wrote a test script with that logic on it and did some runs - it looks OK to me:

uberbrady@GrokBook-Pro snipe-it % /tmp/version.sh 18.03
NOT greater
uberbrady@GrokBook-Pro snipe-it % /tmp/version.sh 18.04
Greater than or equal to 18.04
uberbrady@GrokBook-Pro snipe-it % /tmp/version.sh 17.04
NOT greater
uberbrady@GrokBook-Pro snipe-it % /tmp/version.sh 17.99
NOT greater
uberbrady@GrokBook-Pro snipe-it % /tmp/version.sh 18.05
Greater than or equal to 18.04
uberbrady@GrokBook-Pro snipe-it % /tmp/version.sh 18.06
Greater than or equal to 18.04
uberbrady@GrokBook-Pro snipe-it % /tmp/version.sh 18.99
Greater than or equal to 18.04
uberbrady@GrokBook-Pro snipe-it % /tmp/version.sh 18.04
Greater than or equal to 18.04
uberbrady@GrokBook-Pro snipe-it % /tmp/version.sh 19.04
Greater than or equal to 18.04
uberbrady@GrokBook-Pro snipe-it % /tmp/version.sh 19.00
Greater than or equal to 18.04
uberbrady@GrokBook-Pro snipe-it % /tmp/version.sh 19.01
Greater than or equal to 18.04
uberbrady@GrokBook-Pro snipe-it % /tmp/version.sh 18.04
Greater than or equal to 18.04
uberbrady@GrokBook-Pro snipe-it % /tmp/version.sh 3.04 
NOT greater

Copy link
Collaborator

@uberbrady uberbrady left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@snipe snipe changed the base branch from master to develop November 17, 2020 06:15
@snipe snipe merged commit 4fd6667 into snipe:develop Nov 17, 2020
@welcome
Copy link

welcome bot commented Nov 17, 2020

Congrats on merging your first pull request! 🎉🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants