Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component checkout/checkin fixes. #8008

Merged
merged 6 commits into from
May 1, 2020
Merged

Component checkout/checkin fixes. #8008

merged 6 commits into from
May 1, 2020

Conversation

dmeltzer
Copy link
Contributor

  • Provide proper translated messages for checkin vs checkout
  • Pass appropriate methods to the Checkout event, fixes an error on
    checkin.
  • Default to a value of 1 on checkin in UI to save a click sometimes.

@dmeltzer
Component checkout/checkin fixes.
3586097 
- Provide proper translated messages for checkin vs checkout
- Pass appropriate methods to the Checkout event, fixes an error on
checkin.
- Default to a value of 1 on checkin in UI to save a click sometimes.
@dmeltzer dmeltzer requested a review from snipe as a code owner April 29, 2020 16:53
@dmeltzer
Copy link
Contributor Author

One additional change is that this now validates when editing a components quantity that the new quantity is greater than the number currently checked out.

@dmeltzer
Copy link
Contributor Author

A few more now in this PR:

  • Adjust sorting on the licenseSeat view page to sort as "Seat 1, Seat 2,...Seat 10" rather than "Seat 1, Seat 10, Seat 2"
  • Delete text describing what a consumable/accessory/etc was on the view page for that item--This test was moved/changed in the translations, and it doesn't seem to make sense to show on this page after the adjustments--If you're viewing a consumable you should know what it is, right?
  • Fix a route() issue on licenses that prevented viewing a license.

@snipe snipe merged commit 8507bcd into snipe:develop May 1, 2020
@dmeltzer dmeltzer deleted the component-checkinout-fixes branch May 1, 2020 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snipe snipe Awaiting requested review from snipe snipe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmeltzer @snipe