Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow appending of domain name to username for logins #7790

Merged
merged 1 commit into from
Feb 4, 2020
Merged

Allow appending of domain name to username for logins #7790

merged 1 commit into from
Feb 4, 2020

Conversation

fabiang
Copy link
Contributor

@fabiang fabiang commented Feb 4, 2020

Hello,

my company started to deprecate sAMAccountName in our Active Directory and try to switch all application over to use userPrincipalName. Unfortunately userPrincipalName contains the domain name suffix.

To make it more comfy for our users not require to write "username@domain", I've added a setting to always append the domain name automatically to the username.

See here:

Bildschirmfoto vom 2020-02-04 18-09-33

I've provided translations for English and German. Also the settings field ad_domain is now required when is_ad is checked.

Thanks!

@fabiang fabiang requested a review from snipe as a code owner February 4, 2020 17:17
@snipe
Copy link
Owner

snipe commented Feb 4, 2020

Funny, we were just talking about adding this - nice work, thanks!

@snipe snipe merged commit 5becb93 into snipe:develop Feb 4, 2020
@fabiang fabiang deleted the single-domain branch February 4, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants