LDAP fixes #6533
Merged
LDAP fixes #6533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
smb
commented
Dec 19, 2018
smb
commented
- Move LDAP from model to service
- Fix missing iCheck files in webpack
- Fix initial travis errors (now fails on tests)
… and blue.png to public folder
… and blue.png to public folder
snipe
reviewed
Dec 20, 2018
snipe
reviewed
Dec 20, 2018
snipe
reviewed
Dec 20, 2018
|
If you have a working AD / LDAP environment: feel free to test against this version as i can't do it at the moment. |
|
@snipe are there any more issues with this PR? |
|
No issues with it, just trying to test. We just got back after the holiday break. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.