Revision of #5471 #6148
Merged
Revision of #5471 #6148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the collection of users displayed just filtered the data with the method where() and concat() for the user can search for first name or last name. The solution is case sensitive.
…o querying for the users. Also Case-insensitive.
dmeltzer
reviewed
Sep 5, 2018
| $accessory_users = $accessory_users->where('first_name', $request->input('search'))->concat($accessory_users->where('last_name', $request->input('search'))); | ||
|
|
||
| if ($request->filled('search')) { | ||
| $accessory_users = Accessory::find(1)->users() |
There was a problem hiding this comment.
This should use $accessory->users() correct? Currently you're searching against an accessory with a specific id.
There was a problem hiding this comment.
Ugh, yeah sorry... I actually tried to use 'Accessory::find($id)->users()' but I let the magic number behind. Your solution looks better, thank you.
…ter of AccessoriesController.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #5471. A better solution than the last using collections methods. Now Querying the established relation between Accessory and User