Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable file browsing #5922

Merged
merged 10 commits into from
Jul 24, 2018
Merged

Disable file browsing #5922

merged 10 commits into from
Jul 24, 2018

Conversation

EarlRamirez
Copy link
Contributor

Currently, the public directory can be accessible from the browser, although there is no sensitive data in this directory, it will be best to restrict driectory browsing from the virtual host.

@EarlRamirez EarlRamirez requested a review from snipe as a code owner July 22, 2018 21:47
@EarlRamirez
Copy link
Contributor Author

I think it make better sense to make this change in public/.htaccess file to fix current installations.

@snipe
Copy link
Owner

snipe commented Jul 23, 2018

I would really prefer to not mess with the primary htaccess if possible. That's a file that some folks have customized (with https redirects, etc), and really this should be handled via web server configs. To keep it simpler, we can just put index.html files in the dirs if we really feel like that's something we should be handling, versus it being handled via server config.

@EarlRamirez
Copy link
Contributor Author

In that case, the .htaccess file is out of the question, I do agree with this being managed from the server side, do you foresee any challenges with keeping this change in the virtual host? This will only affect future installations using the install.sh script.

@snipe snipe merged commit ef1e8df into snipe:develop Jul 24, 2018
@snipe
Copy link
Owner

snipe commented Jul 24, 2018

Should be fine, yeah.

@tiagom62
Copy link
Contributor

tiagom62 commented Aug 2, 2018

You may want to also update that here: https://snipe-it.readme.io/docs/linuxosx

From memory that is where i got the virtualhost setup from.

@EarlRamirez
Copy link
Contributor Author

@tiagom62 thanks, plan to update some docs during the weekend.

@EarlRamirez
Copy link
Contributor Author

@tiagom62 document updated

@@ -20,6 +20,7 @@ vim \
git \
cron \
mysql-client \
cron \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cron is already present, just two lines above this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants