Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assetcontroller cleanup #5858

Merged
merged 9 commits into from
Jul 17, 2018
Merged

Assetcontroller cleanup #5858

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
8037a2f
Extract method/cleanup
dmeltzer Apr 19, 2018
9f2302f
Remove apiStore method that is unusued since api controllers.
dmeltzer Apr 19, 2018
97a59ac
Use proper model exception
dmeltzer Apr 19, 2018
9de2849
Remove old user importer. This is now supported by the general impor…
dmeltzer Apr 19, 2018
f2d69ad
Refactor AssetsController methods.
dmeltzer Apr 20, 2018
658a27b
Fix Unit test failing after date changes.
dmeltzer Jul 16, 2018
a653e47
Pass valid string to be translated.
dmeltzer Jul 16, 2018
45b2895
Some method cleanup for codacy.
dmeltzer Jul 16, 2018
53b7117
Extract trait for common checkout uses and codacy fixes.
dmeltzer Jul 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Unit test failing after date changes.
  • Loading branch information
@dmeltzer
dmeltzer committed Jul 16, 2018
commit 658a27b4cb71d66dd34da6bf94ece5aa4e82de73
4 changes: 2 additions & 2 deletions tests/unit/AssetMaintenanceTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ public function it_nulls_out_completion_date_if_blank_or_invalid()
$c->completion_date = '0000-00-00';
$this->assertTrue($c->completion_date===null);
$c->completion_date = '2017-05-12';
$this->assertTrue($c->completion_date==='2017-05-12');
$this->assertTrue($c->completion_date==Carbon::parse('2017-05-12'));

}
}
}